Skip to content

[CodeCompletion] Inherit options when parsing new buffer #31741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2020
Merged

[CodeCompletion] Inherit options when parsing new buffer #31741

merged 1 commit into from
May 13, 2020

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 12, 2020

for fast completions. Options may affect the parsing result.
Also, don't collect interface hash tokens inside inactive blocks.

@rintaro
[CodeCompletion] Inherit options when parsing new buffer
ec0c948 
for fast completions. Options may affect the parsing result.
Also, don't collect interface hash tokens inside inactive blocks.
@rintaro
Copy link
Member Author

rintaro commented May 12, 2020

@swift-ci Please smoke test

@rintaro rintaro requested a review from benlangmuir May 12, 2020 22:47
benlangmuir
benlangmuir approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@benlangmuir benlangmuir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For canImport, would it be possible to take the canImport result from the original AST (just assume it's the same)? That would obviously be a separate change.

@rintaro
Copy link
Member Author

rintaro commented May 12, 2020 •
edited
Loading

For canImport, would it be possible to take the canImport result from the original AST (just assume it's the same)?

An idea is setting up a proxy module loader which delegates 'canImportModule()' to the original AST context.

@rintaro
Copy link
Member Author

rintaro commented May 12, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ec0c948

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ec0c948

@shahmishal
Copy link
Member

@swift-ci Please test

@rintaro rintaro merged commit 14ff43e into swiftlang:master May 13, 2020
@rintaro rintaro mentioned this pull request May 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlangmuir benlangmuir benlangmuir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rintaro @swift-ci @shahmishal @benlangmuir