Skip to content

Adapt Driver Dependencies Test Suite to Private Dependencies #31762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2020

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented May 13, 2020

No description provided.

@CodaFi
Copy link
Contributor Author

CodaFi commented May 13, 2020

@swift-ci smoke test

@davidungar
Copy link
Contributor

The swiftdeps file includes a version at the top. How about incrementing that?

@davidungar
Copy link
Contributor

You have my sympathy! There are a lot of tests to fix.

@CodaFi
Copy link
Contributor Author

CodaFi commented May 13, 2020

We don't need to bump the version number just for private dependencies since the written format is independent of these changes. That is, unless you meant that it should have been incremented a-priori. In which case, I can do the grunt work for that in a follow-up just to make sure I get all the tests in one pass.

@CodaFi
Copy link
Contributor Author

CodaFi commented May 13, 2020

Hm, this is the second time I've seen SourceKit/CodeComplete/complete_checkdeps_bridged.swift fail spuriously...

@swift-ci clean smoke test Linux platform

@davidungar
Copy link
Contributor

Good point about the format being compatible. I'm thinking, though, that even though we don't need to bump it, it could be useful to bump it. Might it offer an easy way to see which authoring strategy is being used in the frontend? For instance when we have to go in and look at a compiler that we didn't build?

@CodaFi
Copy link
Contributor Author

CodaFi commented May 14, 2020

@swift-ci smoke test Linux

@CodaFi
Copy link
Contributor Author

CodaFi commented May 14, 2020

@CodaFi CodaFi merged commit 816b00e into swiftlang:master May 14, 2020
@CodaFi CodaFi deleted the a-little-privacy-please branch May 14, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants