[5.3] Reduce Generic use in Codable #31772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, types generic on the CodingKey produce a lot of runtime metadata. Reducing the number of such types should help with some of the reported memory bloat from Codable. Based on a suggestion of @jckarter Resolves rdar://62620208
|
@swift-ci please test |
airspeedswift
approved these changes
May 13, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.3 cherry-pick of #31278
Explanation: Changes two types that are internal to Codable/Decodable support to not be generic in the CodingKey. This should reduce metadata size for apps that make heavy use of Codable/Decodable
Scope: Changes to private classes within Codable/Decodable implementation
Radar: rdar://62620208
Risk: Possible performance impacts to Codable/Decodable users
Testing: Full CI, local testing, CI benchmarking