Skip to content

[5.3] Make the lazy assignment of an associated type/wtable atomic #31780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2020
Merged

[5.3] Make the lazy assignment of an associated type/wtable atomic #31780

merged 1 commit into from
May 15, 2020

Conversation

rjmccall
Copy link
Contributor

Should fix SR-12760. 5.3 version of #31768.

@rjmccall rjmccall requested review from DougGregor and kubamracek May 14, 2020 04:40
@rjmccall rjmccall requested a review from a team as a code owner May 14, 2020 04:40
@rjmccall
Copy link
Contributor Author

@swift-ci Please test.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 29d8bfd

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 29d8bfd

@rjmccall
Copy link
Contributor Author

Linux failed in SourceKit/CodeComplete/complete_checkdeps_otherfile.swift, which seems unrelated. macOS failed with a hundred unrelated LLDB failures. Great.

@rjmccall
Copy link
Contributor Author

@swift-ci Please test.

@tkremenek tkremenek merged commit 7131885 into swiftlang:release/5.3 May 15, 2020
@rjmccall rjmccall deleted the associated-witness-atomics-5.3 branch May 15, 2020 17:42
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkremenek tkremenek tkremenek approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

@kubamracek kubamracek Awaiting requested review from kubamracek

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rjmccall @swift-ci @tkremenek @theblixguy @AnthonyLatsis