Skip to content

Update docs and tests for LLVMFuzzerTestOneInput #31802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2020
Merged

Update docs and tests for LLVMFuzzerTestOneInput #31802

merged 1 commit into from
May 16, 2020

Conversation

benrimmington
Copy link
Contributor

@benrimmington benrimmington commented May 15, 2020 •
edited
Loading

  • Add note on libFuzzer availability to docs.
  • Use parameters suitable for UnsafeRawBufferPointer.
    • (Swift uses Int for size_t.)
  • Replace #if os(...) checks with canImport checks.
  • Move slowest test from test/Fuzzing to validation-test/Sanitizers.
  • Remove superfluous test file.

harlanhaskins
harlanhaskins reviewed May 15, 2020
View reviewed changes
@benrimmington benrimmington force-pushed the llvm-fuzzer-test-one-input branch from f1695c6 to 8e8afcf Compare May 15, 2020 01:12
harlanhaskins
harlanhaskins reviewed May 15, 2020
View reviewed changes
@benrimmington benrimmington force-pushed the llvm-fuzzer-test-one-input branch from 8e8afcf to ec8149e Compare May 15, 2020 01:19
@CodaFi
Copy link
Contributor

CodaFi commented May 15, 2020

@swift-ci smoke test

harlanhaskins
harlanhaskins reviewed May 15, 2020
View reviewed changes
@benrimmington
Copy link
Contributor Author

All checks have passed.

Should the fuzzer test be moved from test/Fuzzing to test/Sanitizers?

Or should it be moved to validation-test/Sanitizers, because it is the slowest test on swift-ci?

454.80s: Swift(macosx-x86_64) :: Fuzzing/fuzzer_test.swift

@harlanhaskins
Copy link
Contributor

Yeah that should definitely be moved to validation-test at the very least.

@benrimmington benrimmington force-pushed the llvm-fuzzer-test-one-input branch from ec8149e to 329dbb5 Compare May 15, 2020 23:53
@harlanhaskins
Copy link
Contributor

@swift-ci smoke test

@benrimmington
Copy link
Contributor Author

All checks have passed.

@harlanhaskins Thanks for your help.

@harlanhaskins harlanhaskins merged commit 2e0ca0b into swiftlang:master May 16, 2020
@harlanhaskins
Copy link
Contributor

Thanks, @benrimmington!

@benrimmington benrimmington deleted the llvm-fuzzer-test-one-input branch May 16, 2020 02:07
@benrimmington benrimmington mentioned this pull request May 16, 2020
Merged
valeriyvan pushed a commit to valeriyvan/swift that referenced this pull request May 16, 2020
@benrimmington @valeriyvan
Update docs and tests for LLVMFuzzerTestOneInput (swiftlang#31802)
a50087a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harlanhaskins harlanhaskins harlanhaskins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benrimmington @CodaFi @harlanhaskins