[cmake] Get the default value for LLVM_ENABLE_ASSERTIONS from LLVMCon… #3182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge |
| # If we did not have a cached value for LLVM_ENABLE_ASSERTIONS, set | ||
| # LLVM_ENABLE_ASSERTIONS_saved to be the ENABLE_ASSERTIONS value from LLVM so | ||
| # we follow LLVMConfig.cmake's value by default if nothing is provided. | ||
| if (NOT LLVM_ENABLE_ASSERTIONS_saved) |
There was a problem hiding this comment.
This treats "assertions explicitly disabled" and "assertions not set" the same, doesn't it?
There was a problem hiding this comment.
Yes. I am going to fix it.
…fig.cmake. rdar://26154980
gottesmm
force-pushed
the
migrate_llvm_assertions_to_use_llvm_config.cmake
branch
from
fe98a1d to
87fc9ca
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
…fig.cmake.
rdar://26154980