[ASTPrinter] Don't print inferred opaque result type witness #31821
Conversation
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
ide-completion-rdar59817674
branch
from
2d3e0e3 to
90867c2
Compare
Opaque result type syntax is not usable except the declaration of itself. In other places, users need to let them inferred. If they are inferred associated type, they need to reffered by the name of the associated type. rdar://problem/59817674
rintaro
force-pushed
the
ide-completion-rdar59817674
branch
from
90867c2 to
29398b1
Compare
|
@swift-ci Please smoke test |
| value.#^POSTFIX_ConcreteTestProtocol2^# | ||
| // POSTFIX_ConcreteTestProtocol2: Begin completions | ||
| // POSTFIX_ConcreteTestProtocol2-DAG: Keyword[self]/CurrNominal: self[#ConcreteTestProtocol2#]; | ||
| // POSTFIX_ConcreteTestProtocol2-DAG: Decl[InstanceMethod]/CurrNominal: foo()[#Comparable#]; |
There was a problem hiding this comment.
I think I understand the issue with override completions, but why does it impact member completion type annotation?
There was a problem hiding this comment.
Do you mean why this is printed as Comparable instead of some Comparable? If so, that's because we decided not to print some when it was introduced.
Or why bar()[#ConcreteTestProtocol2.Assoc#]? This is actually a side effect of my change, but when thinking about baz({#x: ConcreteTestProtocol2.Assoc#})[#(ConcreteTestProtocol2.Assoc) -> ConcreteTestProtocol2.Assoc#], I think It's better than (Comparable) -> Comparable because the result function doesn't accept arbitrary Comparable.
There was a problem hiding this comment.
Do you mean why this is printed as Comparable instead of some Comparable? If so, that's because we decided not to print some when it was introduced.
This is what I meant, thanks for explaining. I forgot that, and I misread some of the other test cases to think this was making it inconsistent.
Opaque result type syntax is not usable except at the declaration itself. In other places, users need to let them inferred. Or, if they are used as associated types, they can only be referred by the name of the associated types.
In
substType(), if a type witness is found to be a opaque result type, use the interface type of the witness decl which is a implicit typealias decl/type.rdar://problem/59817674
rdar://problem/62232092