[silgen] Rename DelegateInitSelfWritebackCleanup -> OwnedValueWritebackCleanup. #31828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
This is just a rename |
slavapestov
approved these changes
May 16, 2020
…ckCleanup. This cleanup is meant to be used with a value that is temporarily taken from a memory location for a lexical scope. At end of scope, the value is returned back to the original memory location. It is used to implement in SILGen "move only loadable values". Note, a "move only loadable value" is not a "move only type". It is just an abstraction for working with a single copy of a loadable value as if that single copy was a move only value. This is currently only being used in initializer emission since we treat self in such a context as a "move only value" before we delegate to a super/convenience/peer initializer since we have to allow for such initializers to change the underlying class we have stored which in certain use cases require self to be guaranteed as /never/ being retained. The move only value representation makes this easy to do/enforce. My hope is that by changing the name of this cleanup it is more obvious what it is meant to do and can become (hopefully) generally useful.
gottesmm
force-pushed
the
pr-8a70d10c810395208df9168b83d620b32b86f985
branch
from
1880d59 to
c217262
Compare
|
@swift-ci smoke test |
|
@swift-ci test windows platform |
|
@swift-ci smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleanup is meant to be used with a value that is temporarily taken from a
memory location for a lexical scope. At end of scope, the value is returned back
to the original memory location.
It is used to implement in SILGen "move only loadable values". Note, a "move
only loadable value" is not a "move only type". It is just an abstraction for
working with a single copy of a loadable value as if that single copy was a move
only value.
This is currently only being used in initializer emission since we treat self in
such a context as a "move only value" before we delegate to a
super/convenience/peer initializer since we have to allow for such initializers
to change the underlying class we have stored which in certain use cases require
self to be guaranteed as /never/ being retained. The move only value
representation makes this easy to do/enforce.
My hope is that by changing the name of this cleanup it is more obvious what it
is meant to do and can become (hopefully) generally useful.
Part of: rdar://problem/59830255