Skip to content

[CMake] Allow devs to disable implicit incremental testing #31840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2020

Conversation

davezarzycki
Copy link
Contributor

@davezarzycki davezarzycki commented May 16, 2020

Lit's incremental mode is incompatible with read-only source filesystems which some CI setups use and there is no way to disable incremental mode in Swift without enabling --shuffle via LLVM_LIT_ARGS.

@davezarzycki davezarzycki requested review from compnerd and gottesmm May 16, 2020 15:33
@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test

@compnerd
Copy link
Member

compnerd commented May 16, 2020

What do you think of changing this to something like:

set(SWIFT_LIT_ARGS "--incremental" CACHE STRING
  "arguments to pass to lit")

This will allow you to override the parameter without an option while allowing greater control over the arguments.

If you think that this is too much freedom, the option makes sense.

Lit's incremental mode is incompatible with read-only source filesystems
which some CI setups use and there is no way to disable incremental mode
in Swift without enabling --shuffle via LLVM_LIT_ARGS.
@davezarzycki
Copy link
Contributor Author

That seems better than what I proposed.

@swift-ci please smoke test

@davezarzycki davezarzycki merged commit bfffbbf into swiftlang:master May 17, 2020
@davezarzycki davezarzycki deleted the pr31840 branch May 17, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants