Skip to content

Revert "[IRGen testing] Fix bogus FileCheck check-prefix "-SAME" usage" #31843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2020

Conversation

compnerd
Copy link
Member

Reverts #31839

Revert to get Windows green.

@compnerd
Copy link
Member Author

CC: @davezarzycki

@compnerd
Copy link
Member Author

@swift-ci please test

@davezarzycki
Copy link
Contributor

That’s fine. That being said, if windows testing clean effectively blocks commits, then it should be required before merging, right? CC: @shahmishal

@benrimmington
Copy link
Contributor

@davezarzycki There's also an iOS failure in Build #20863 (using "test" instead of "smoke test").

FAIL: Swift(iphonesimulator-i386) :: IRGen/class_resilience.swift (11888 of 13208)
******************** TEST 'Swift(iphonesimulator-i386) :: IRGen/class_resilience.swift' FAILED ********************

@compnerd compnerd merged commit 3280bf8 into master May 16, 2020
@compnerd compnerd deleted the revert-31839-pr31839 branch May 16, 2020 23:24
@davezarzycki
Copy link
Contributor

Hi @benrimmington – I'm struggling to reproduce the 32-bit error. How are people supposed to run the 32-bit simulator these days? Does that require a copy of macOS earlier than Catalina?

@benrimmington
Copy link
Contributor

@davezarzycki I haven't tried recently, but it used to require a 32-bit iOS simulator with a specific name (e.g. "iPhone 5"). I'm trying it now to see what the actual name should be.

The last 32-bit device was the iPhone 5, which supports up to iOS 10.3.4; and the oldest simulator available to download (in the latest Xcode + macOS) is "iOS 10.3.1 Simulator".

@davezarzycki
Copy link
Contributor

davezarzycki commented May 18, 2020

@davezarzycki I haven't tried recently, but it used to require a 32-bit iOS simulator with a specific name (e.g. "iPhone 5"). I'm trying it now to see what the actual name should be.

The last 32-bit device was the iPhone 5, which supports up to iOS 10.3.4; and the oldest simulator available to download (in the latest Xcode + macOS) is "iOS 10.3.1 Simulator".

Right. I get bunch of “Invalid device: iPhone 5” errors and xcrun simctl list doesn’t list iPhone 5 as a valid device for 10.3 despite the fact that it should be there. I’d wager that macOS Catalina effectively cut off 32-bit simulators from working

@benrimmington

This comment has been minimized.

@benrimmington
Copy link
Contributor

I've created #31866 to update the Testing.md document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants