Skip to content

Fixed Desciption of unconditional_checked_cast_addr in SIL.rst #31847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2020
Merged

Fixed Desciption of unconditional_checked_cast_addr in SIL.rst #31847

merged 1 commit into from
May 18, 2020

Conversation

freddi-kit
Copy link
Contributor

@freddi-kit freddi-kit commented May 17, 2020

What is it?

Fixing unconditional_checked_cast_addr description in SIL.rst

Why

Looks the description of unconditional_checked_cast_addr is a little wrong.
There is a %1 in the description of example code, but not shown on the example code of it (Looks SIL value of second oprand is wrong).

For Info

The bnf of unconditional_checked_cast_add is like below,

sil-instruction ::= 'unconditional_checked_cast_addr'
                     sil-type 'in' sil-operand 'to'
                     sil-type 'in' sil-operand

but example of it is following wrong format.

unconditional_checked_cast_addr $A in %0 : $@thick A to $B in $@thick B

The secound sil-operand is sil-type only but actual format of sil-operand is

sil-operand ::= sil-value ':' sil-type

@theblixguy theblixguy requested a review from gottesmm May 17, 2020 17:04
Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gottesmm
Copy link
Contributor

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit eec5c01 into swiftlang:master May 18, 2020
@freddi-kit freddi-kit deleted the fix/unconditional_checked_cast_addr branch May 18, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants