Invert if statement in filesystem for clearer intent. #31865
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
From the top down of the code, the code checks to see if the file sizes are different, then to check if they are 0, and then to compare the memory contents. However, the first early return in that portion is to return DifferentContents, and then check for 0 sizes and if they are then return SameContents. However on the bottom, it checks to see if the memory difference is 0.
To make the code clearer in its intent, I changed the if statement so it would return DifferentContents if memcmp was non-0, and then otherwise say they are the same contents.