[ConstraintSystem] Add a new locator element - argument attribute
#31867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ArgumentAttribute` points to a particular attribute associated with one of the arguments e.g. `inout` or its type e.g. `@escaping`. This is very useful when dealing with argument-to-parameter failures because it allows to express in the locator kind of a problem.
… handle `ArgumentAttribute` - `getCalleeLocator`, if given locator ends at `ArgumentAttribute` strip the last element which makes sure that produced locator always refers directly to argument-to-parameter conversion. - `simplifyLocator`, always leave `ArgumentAttribute` in the path because it's useful for diagnostics.
If either `MarkExplicitlyEscaping` or `TreatRValueAsLValue` fix points to an argument-to-parameter conversion, let's add more more clarifying argument to the locator to pinpoint the problem.
|
@swift-ci please smoke test |
hborla
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArgumentAttributepoints to a particular attribute associatedwith one of the arguments e.g.
inoutor its type e.g.@escaping.This is very useful when dealing with argument-to-parameter
failures because it allows to express in the locator kind
of a problem.
ArgumentAttributeelement is useful for new approach to ambiguity diagnostics(#31713) because it makes it possible
to unambiguously point out that a certain failures are associated with an
argument to a call instead of a call itself.