Reenable a test for UnicodeScalar #31883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was disabled back in 2017 when the new integer protocols were landing due to regressions in error messages. It is better to have a working test that verifies the desired behavior (UnicodeScalar not supporting arithmetic and the type checker producing somewhat readable messages), rather than a disabled test because the error messages are not perfect.
|
@swift-ci Please test |
|
Seems like this should be a Sema test. |
|
We have a bunch of |
|
Hm, yeah. Unless they're specifically testing warnings or errors produced by stdlib itself, I think they don't belong there. |
|
These are separable concerns. I'm going to merge this. ⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was disabled back in 2017 when the new integer protocols were landing due to regressions in error messages. It is better to have a working test that verifies the desired behavior (UnicodeScalar not supporting arithmetic and the type checker producing somewhat readable messages), rather than a disabled test because the error messages are not perfect.