Skip to content

No dummy constraint in the public swiftinterface for SPI extensions #31896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2020
Merged

No dummy constraint in the public swiftinterface for SPI extensions #31896

merged 1 commit into from
May 19, 2020

Conversation

xymus
Copy link
Contributor

@xymus xymus commented May 19, 2020 •
edited
Loading

Don't print the dummy constraint _ConstraintThatIsNotPartOfTheAPIOfThisLibrary for SPI extensions in the public swiftinterface.

rdar://problem/63352700

This will also require type-checking improvements to detect problematic SPI extensions earlier.

@xymus
Copy link
Contributor Author

xymus commented May 19, 2020

@swift-ci Please smoke test

@xymus xymus requested a review from nkcsgexi May 19, 2020 20:29
@xymus xymus mentioned this pull request May 19, 2020
Merged
nkcsgexi
nkcsgexi approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xymus xymus merged commit dbb5949 into swiftlang:master May 19, 2020
@xymus xymus deleted the fix-dummy-constraint branch May 19, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xymus @nkcsgexi