Emit /DEFAULTLIB directive for #pragma comment(lib, ...) in a C module
#31913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule. This is important, for example, for linking correctly to the C++ standard library on Windows, which uses `#pragma comment(lib, ...)` in its headers to specify the correct library to link against.
|
@swift-ci Please test |
compnerd
approved these changes
May 20, 2020
There was a problem hiding this comment.
This seems reasonable to me. Doug may have opinions as well.
CC: @DougGregor
|
CC: @belkadan - can't leave Jordan off this! |
|
Merging, as there haven't been any further comments in a week. |
|
Looks totally reasonable, sorry I didn't see this before |
NP, thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important, for example, for linking correctly to the C++
standard library on Windows, which uses
#pragma comment(lib, ...)inits headers to specify the correct library to link against.