[5.3] [Typechecker] Emit a specialised diagnostic for redeclaration errors when the declaration is synthesised #31938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when the declaration is synthesized
…earest non-implicit decl context
|
@swift-ci please test |
tkremenek
approved these changes
May 21, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #31915
Explanation: We are not diagnosing redeclaration errors when the declarations involved are synthesised. This sometimes leads to compiler crashes. Upon investigation, this is a regression caused by #31037.
Scope: Affects situations where we have re-declarations.
SR Issue: SR-12839 / rdar://problem/63496795
Risk: Low. This fixes a compiler crash while also emitting improved diagnostics.
Testing: Added new tests which pass on Swift CI and updated some existing ones.
Reviewed by: @hborla