[NFC][SourceManager] Rename line and column APIs for clarity

[owenv]

getLineAndColumn -> getPresumedLineAndColumnForLoc (respects #sourceLocation )
getLineNumber -> getLineAndColumnInBuffer (doesn't respect #sourceLocation )

This is a purely mechanical change (via Xcode refactoring) that applies some of the renaming suggested in https://forums.swift.org/t/filename-line-and-column-for-sourceloc/5463 by @rintaro . I've also been auditing calls to these methods to find incorrect uses, I'm going to split those into multiple PRs because they'd make this too hard to review.

Some of the other SourceManager API should probably be renamed too, but I think this s a good first step and will help address the most common cases of misuse.

[akyrtzi]

Nice one, thank you! 👍

[rintaro]

Thanks!

[rintaro]

@swift-ci Please smoke test

[rintaro]

@swift-ci Please smoke test

[rintaro]

@owenv lldb needs to be updated.

/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/llvm-project/lldb/source/Symbol/SwiftASTContext.cpp:2644:29: error: no member named 'getLineAndColumn' in 'swift::SourceManager'
      line_col = source_mgr.getLineAndColumn(source_loc);
                 ~~~~~~~~~~ ^

[owenv]

swiftlang/llvm-project#1252

@swift-ci please smoke test

[rintaro]

swiftlang/llvm-project#1252
@swift-ci Please test Windows

[rintaro]

swiftlang/llvm-project#1252
@swift-ci Please test Windows

[rintaro]

Windows bots don't support cross repo PR testing. @owenv feel free to merge this.

[owenv]

@rintaro sounds good, thanks! I’m rerunning tests on the other PR now due to some CI flakiness. If those pass I may need some help merging this as I don’t have llvm-project commit access

[hamishknight]

@owenv Unfortunately it's not flakiness, the Linux bot is currently failing for all swift/master LLVM PRs :(

[owenv]

@hamishknight oh, thanks for the heads up, I hadn’t noticed the issue was more widespread. In that case I’ll just pick this back up next week, it’s pretty non-urgent