Skip to content

[NFC][SwiftSyntax] Fix 'Traling' typo #31957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2020
Merged

[NFC][SwiftSyntax] Fix 'Traling' typo #31957

merged 1 commit into from
May 22, 2020

Conversation

xwu
Copy link
Collaborator

@xwu xwu commented May 22, 2020

This PR amends #31052 to correct a (user-facing?) typo.

swift-syntax: swiftlang/swift-syntax#220

@xwu
Copy link
Collaborator Author

xwu commented May 22, 2020

(cc @rintaro @rjmccall)

@xwu
Copy link
Collaborator Author

xwu commented May 22, 2020

@xwu
Copy link
Collaborator Author

xwu commented May 22, 2020

Ideally, we would incorporate this fix into 5.3, yes?

Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Yes, please we want this for 5.3

Right!

@xwu
Copy link
Collaborator Author

xwu commented May 22, 2020

Great. I will cherry-pick this change after it's merged into master.
@rintaro I'll need you to merge the swift-syntax PR, as I don't have commit access to that repo.

@rintaro
Copy link
Member

rintaro commented May 22, 2020

@akyrtzi can force merge the swift-syntax PR tomorrow.

@xwu
Copy link
Collaborator Author

xwu commented May 22, 2020

Ping @akyrtzi—please let me know when you're ready to merge the swift-syntax PR, or feel free to merge this PR simultaneously yourself. Thanks!

@akyrtzi akyrtzi merged commit de366c4 into swiftlang:master May 22, 2020
@xwu xwu deleted the tralala branch May 22, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants