[5.3][Property Wrappers] Fix handling of properties that are default initialized via property wrapper #31958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to return a string representing default initialization when a property is default initialized via property wrapper.
…lized via property wrapper, mark the init call as implicit.
|
@swift-ci please test |
tkremenek
approved these changes
May 22, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #31949
Reviewer: @DougGregor
ParamDecl::getDefaultValueStringRepresentation, only attempt to extract the text for an initial wrapped value if the property has a wrapped value placeholder in the initializer call. Otherwise, the compiler will crash when serializing the memberwise initializer.()on the property wrapper attribute), mark the init call as implicit. There are assertions elsewhere (e.g. inSemaAnnotator::handleCustomAttributes) that expect an explicit argument on the custom attribute if the initializer is not implicit.Resolves: rdar://problem/59471019