Propagate -vfsoverlay from driver to frontend.
#31970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @CodaFi |
|
Looks good. Could you add one more FileCheck test that multiple vfs overlays get propagated down to the frontend invocations in order. |
Today, the driver does not propagate the flag to the frontend but also does not emit an error (silently consuming the flag instead). I'll open a similar PR for apple/swift-driver once this one is merged, in case there are any issues that need to be worked out first. Fixes SR-12834.
allevato
force-pushed
the
driver-vfsoverlay
branch
from
07c6295 to
966ffbb
Compare
Done! |
|
@swift-ci smoke test |
CodaFi
approved these changes
May 22, 2020
allevato
added a commit
to allevato/swift-driver
that referenced
this pull request
May 22, 2020
This is the companion to swiftlang/swift#31970 in the C++ driver.
|
Thank you! |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, the driver does not propagate the flag to the frontend but also does not emit an error (silently consuming the flag instead).
I'll open a similar PR for apple/swift-driver once this one is merged, in case there are any issues that need to be worked out first.
Fixes SR-12834.