[ConstraintSystem][NFC] Make test file named argument_matching.swift
#31978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`argument_matching.swift` in test. New filename indicates that is also contains a test case for matching of unlabeled arguments.
from `diagnostics.swift` to `argument_matching.swift` which has more specific interest.
|
LGTM! :) |
|
@swift-ci please smoke test |
xedin
approved these changes
May 22, 2020
|
@swift-ci Please smoke test Windows |
|
A last one error on windows isn’t related. I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make test file named
argument_matching.swiftby renaming fromkeyword_argument.swift.New filename indicates that is contains test cases for matching of not only labeled argument but also unlabeled.
Move test cases about argument matching from
diagnostics.swifttoargument_matching.swiftwhich has more specific interest.This patch only changes place of test cases.
It doesn't have changes about compiler.
I planned this patch in response to comment here.
#31934
@xedin @LucianoPAlmeida Please review this