Skip to content

Use swift tablegen instead of llvm tablegen #3200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

What's in this pull request?

Resolved bug number: (SR-)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@gottesmm
Copy link
Contributor Author

NOTE I am going to improve the commit message in the last commit. I just gotta run to an appointment and wanted to run a smoke test.

@gottesmm
Copy link
Contributor Author

@swift-ci Please smoke test

@gottesmm gottesmm force-pushed the use_swift_tablegen_instead_of_llvm_tablegen branch 2 times, most recently from 3e89c60 to 23c3219 Compare June 25, 2016 00:06
@gottesmm
Copy link
Contributor Author

@swift-ci Please smoke test

…GEN_EXE variable.

This eliminates us setting an LLVM_ prefixed variable in a situation where there is
a viable alternative.

We want to eliminate as many of these as possible since they can cause conflicts
with variables set in LLVMConfig.cmake.

I also added some convenience tablegen functions in AddSwiftTableGen.cmake and
changed all tblgen users to use that instead.

rdar://26154980
@gottesmm gottesmm force-pushed the use_swift_tablegen_instead_of_llvm_tablegen branch from 23c3219 to 5d984de Compare June 25, 2016 00:19
@gottesmm
Copy link
Contributor Author

@swift-ci Please smoke test

@gottesmm gottesmm changed the title [wip] Use swift tablegen instead of llvm tablegen Use swift tablegen instead of llvm tablegen Jun 25, 2016
@gottesmm gottesmm merged commit bd43806 into swiftlang:master Jun 25, 2016
@gottesmm gottesmm deleted the use_swift_tablegen_instead_of_llvm_tablegen branch June 25, 2016 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant