-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[CodeCompletion] Fix non-determinisc failures in dependency check test cases #32030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please test |
Build failed |
@@ -36,6 +35,7 @@ func foo() { | |||
// RUN: -req=complete -pos=5:3 %s -- ${COMPILER_ARGS[@]} == \ | |||
|
|||
// RUN: -shell -- echo '### Modify bridging header library file' == \ | |||
// RUN: -shell -- sleep $SLEEP_TIME == \ | |||
// RUN: -shell -- cp -R $INPUT_DIR/MyProject_mod/LocalCFunc.h %t/MyProject/ == \ | |||
// RUN: -shell -- sleep $SLEEP_TIME == \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the second sleep really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's not needed, but just I wanted to be on the safe side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we try removing it, it's better if we don't make tests unnecessarily slower.
@swift-ci Please test |
Build failed |
…t cases Sleep a few seconds to ensure the timestamp of the modified files are different from the last completion. rdar://problem/62923248
8c6796a
to
ad51f4f
Compare
@swift-ci Please test |
Build failed |
Build failed |
@swift-ci Please test Linux |
Build failed |
@swift-ci Please smoke test Linux |
1 similar comment
@swift-ci Please smoke test Linux |
Sleep a few seconds to ensure the timestamps of the modified files are different from the last completion.
rdar://problem/62923248