Add a Regression Test For Scenario Improved By Private Dependencies #32032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
davidungar
approved these changes
May 27, 2020
test/Incremental/Inputs/superfluous-cascade/definesPoint-after.swift
Outdated
Show resolved
Hide resolved
slavapestov
approved these changes
May 27, 2020
test/Incremental/Inputs/superfluous-cascade/definesPoint-after.swift
Outdated
Show resolved
Hide resolved
The basic setup is this - Suppose that three files define four types:
// File 1
struct A {}
// File 2
struct B { let x: A }
struct C { }
// File 3
struct D { let x: C }
If type 'A' is perturbed, we could expect that File 2 would rebuild
because B has a member of type A. What we don't expect is for File 3 to
rebuild, but thanks to cascading edges that is precisely that happens!
This is because the member x in File 3 creates a cascading edge to File
2, and that edge is traversed while evaluating the cascading edge from
File 2 to File 1. With private dependencies, the expected rebuild
behavior is restored. Commit a regression test to this effect.
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci smoke test |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic setup is this - Suppose that three files define four types:
If type 'A' is perturbed, we could expect that File 2 would rebuild
because B has a member of type A. What we don't expect is for File 3 to
rebuild, but thanks to cascading edges that is precisely that happens!
This is because the member x in File 3 creates a cascading edge to File
2, and that edge is traversed while evaluating the cascading edge from
File 2 to File 1. With private dependencies, the expected rebuild
behavior is restored. Commit a regression test to this effect.