[NFC][ConstraintSystem] Move some inlined header methods to implementation file

[LucianoPAlmeida]

The initial intention was just to audit and see if some methods could be moved to implementation instead of inline in the header. As commented in another PR normally is recommended to inline only small methods.
There is not a precise definition of what is a small method, but I thought in propose moving those in this PR.
While moving I note, that these specific methods have almost exactly the same implementation, so I try to abstract the common logic which seems like an improvement, but TBH not sure if it is worthed nor got much better ... but sending anyway to see what you think cc @xedin @DougGregor

[xedin]

I like this, I left a couple of minor comments inline.

[LucianoPAlmeida]

@DougGregor as you were one of the last people to modify those methods, pinging for a review :)

[LucianoPAlmeida]

@xedin We haven't heard from @DougGregor yet, but since this is a quite simple NFC change I wonder if we could move on? No problem waiting, I'm just doing some checking in some open PR's :)

[xedin]

I think this is good to go. Do you want me to merge it? (I thought that you going to merge it once you get committer access).

[LucianoPAlmeida]

I think this is good to go. Do you want me to merge it? (I thought that you going to merge it once you get committer access).

Ahh, yes I have the commit access so I can merge it, but still waiting for the access to trigger the CI... so can you kick it then? :)

[xedin]

@swift-ci please smoke test

[LucianoPAlmeida]

Thanks :)
Windows build failure seems unrelated, should we kick it again?

[xedin]

@swift-ci please smoke test Windows platform

[xedin]

If it fails with unrelated problem again - don’t worry and merge.

[LucianoPAlmeida]

If it fails with unrelated problem again - don’t worry and merge.

Oh right, thanks :)