Skip to content

[NFC] Pre- increment and decrement where possible #32118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AnthonyLatsis
Copy link
Collaborator

No description provided.

@CodaFi
Copy link
Contributor

CodaFi commented Jun 1, 2020

I assume you used clang-tidy to find these, right?

@CodaFi
Copy link
Contributor

CodaFi commented Jun 1, 2020

The overall refactor LGTM. We should get more eyes on this due to its size and scope, though.

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Jun 1, 2020

I assume you used clang-tidy to find these, right?

Not really. But now I know what to do next time :-)

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test Linux

1 similar comment
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test Linux

@AnthonyLatsis AnthonyLatsis merged commit 267e32d into swiftlang:master Jun 2, 2020
@AnthonyLatsis AnthonyLatsis deleted the post-increment-cleanup branch June 2, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants