Skip to content

Add a [nonoverridden] kind for SILVTable entries. #32126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jckarter
Copy link
Contributor

@jckarter jckarter commented Jun 1, 2020

This will let us track class methods that must exist for pass ordering, interface, or ABI reasons, but which can be given more efficient runtime representation because they have no overrides.

This will let us track class methods that must exist for pass ordering, interface, or ABI reasons, but which can
be given more efficient runtime representation because they have no overrides.
@jckarter
Copy link
Contributor Author

jckarter commented Jun 1, 2020

@swift-ci Please test

@compnerd
Copy link
Member

compnerd commented Jun 1, 2020

Might it not be valuable to have a round trip test?

@swift-ci
Copy link
Contributor

swift-ci commented Jun 1, 2020

Build failed
Swift Test Linux Platform
Git Sha - 564c1a5

@compnerd
Copy link
Member

compnerd commented Jun 2, 2020

@swift-ci please test Linux platform

@jckarter
Copy link
Contributor Author

jckarter commented Jun 2, 2020

@compnerd Sure, I wanted to get the module version break in first, I'm going to add stuff that starts exercising it next.

@jckarter jckarter merged commit fb8bfce into swiftlang:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants