Skip to content

[semantic-arc-opts] Perform a rename/add some comments after talking with @atrick. #32144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Jun 2, 2020

This should add additional clarity to the pass's impl.

@gottesmm gottesmm requested a review from atrick June 2, 2020 19:02
@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 2, 2020

@swift-ci smoke test

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

…with @atrick.

This should add additional clarity to the pass's impl.
@gottesmm gottesmm force-pushed the pr-d8ab9968bdf338be530e1fd4be99884045bc2605 branch from 887da03 to 660384f Compare June 2, 2020 19:26
@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 2, 2020

@swift-ci smoke test

3 similar comments
@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 2, 2020

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 2, 2020

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 2, 2020

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 2, 2020

@swift-ci test windows platform

@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 3, 2020

@swift-ci smoke test

@gottesmm gottesmm merged commit d3a5be4 into swiftlang:master Jun 3, 2020
@gottesmm gottesmm deleted the pr-d8ab9968bdf338be530e1fd4be99884045bc2605 branch June 3, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants