Skip to content

Build-script: propagate the build type to the xctest build script #3226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2016

Conversation

jamala
Copy link
Contributor

@jamala jamala commented Jun 27, 2016

What's in this pull request?

This updates the build script to pass debug/release to XCTest's build script.

Resolved bug number: (SR-1048)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@jamala
Copy link
Contributor Author

jamala commented Jun 27, 2016

@modocache

@modocache
Copy link
Contributor

modocache commented Jun 27, 2016

Thanks, @jamala!

It looks like you added --debug and --release flags to the build_script.py test subcommand in swiftlang/swift-corelibs-xctest#128. utils/build-script-impl also invokes the test subcommand; could you update this pull request to pass the correct flags when testing XCTest as well?

(I'll kick off @swift-ci tests for this pull request after merging swiftlang/swift-corelibs-xctest#128.)

@modocache
Copy link
Contributor

Just testing, not merging. Waiting to hear back about passing the --debug and --release flags to the test action.

@swift-ci please test

@jamala
Copy link
Contributor Author

jamala commented Jun 28, 2016

Updated the test action.

@modocache
Copy link
Contributor

@swift-ci please test and merge

@swift-ci swift-ci merged commit 8456dac into swiftlang:master Jun 28, 2016
@modocache
Copy link
Contributor

Thanks, @jamala!! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants