Skip to content

[AutoDiff] Improve debugging utilities. #32269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions include/swift/SILOptimizer/Differentiation/AdjointValue.h
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,12 @@ class AdjointValue final {
void print(llvm::raw_ostream &s) const {
switch (getKind()) {
case AdjointValueKind::Zero:
s << "Zero";
s << "Zero[" << getType() << ']';
break;
case AdjointValueKind::Aggregate:
s << "Aggregate<";
s << "Aggregate[" << getType() << "](";
if (auto *decl =
getType().getASTType()->getStructOrBoundGenericStruct()) {
s << "Struct>(";
interleave(
llvm::zip(decl->getStoredProperties(), base->value.aggregate),
[&s](std::tuple<VarDecl *, const AdjointValue &> elt) {
Expand All @@ -151,7 +150,6 @@ class AdjointValue final {
},
[&s] { s << ", "; });
} else if (getType().is<TupleType>()) {
s << "Tuple>(";
interleave(
base->value.aggregate,
[&s](const AdjointValue &elt) { elt.print(s); },
Expand All @@ -162,10 +160,11 @@ class AdjointValue final {
s << ')';
break;
case AdjointValueKind::Concrete:
s << "Concrete(" << base->value.concrete << ')';
s << "Concrete[" << getType() << "](" << base->value.concrete << ')';
break;
}
}

SWIFT_DEBUG_DUMP { print(llvm::dbgs()); };
};

Expand Down
7 changes: 7 additions & 0 deletions include/swift/SILOptimizer/Differentiation/PullbackEmitter.h
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,13 @@ class PullbackEmitter final : public SILInstructionVisitor<PullbackEmitter> {
return pullbackTrampolineBBMap.lookup({originalBlock, successorBlock});
}

//--------------------------------------------------------------------------//
// Debugging utilities
//--------------------------------------------------------------------------//

void printAdjointValueMapping();
void printAdjointBufferMapping();

public:
//--------------------------------------------------------------------------//
// Entry point
Expand Down
60 changes: 60 additions & 0 deletions lib/SILOptimizer/Differentiation/PullbackEmitter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,66 @@ void PullbackEmitter::addToAdjointBuffer(SILBasicBlock *origBB,
accumulateIndirect(adjointBuffer, rhsBufferAccess, loc);
}

//--------------------------------------------------------------------------//
// Debugging utilities
//--------------------------------------------------------------------------//

void PullbackEmitter::printAdjointValueMapping() {
// Group original/adjoint values by basic block.
llvm::DenseMap<SILBasicBlock *, llvm::DenseMap<SILValue, AdjointValue>> tmp;
for (auto pair : valueMap) {
auto origPair = pair.first;
auto *origBB = origPair.first;
auto origValue = origPair.second;
auto adjValue = pair.second;
tmp[origBB].insert({origValue, adjValue});
}
// Print original/adjoint values per basic block.
auto &s = getADDebugStream() << "Adjoint value mapping:\n";
for (auto &origBB : getOriginal()) {
if (!pullbackBBMap.count(&origBB))
continue;
auto bbValueMap = tmp[&origBB];
s << "bb" << origBB.getDebugID();
s << " (size " << bbValueMap.size() << "):\n";
for (auto valuePair : bbValueMap) {
auto origValue = valuePair.first;
auto adjValue = valuePair.second;
s << "ORIG: " << origValue;
s << "ADJ: " << adjValue << '\n';
}
s << '\n';
}
}

void PullbackEmitter::printAdjointBufferMapping() {
// Group original/adjoint buffers by basic block.
llvm::DenseMap<SILBasicBlock *, llvm::DenseMap<SILValue, SILValue>> tmp;
for (auto pair : bufferMap) {
auto origPair = pair.first;
auto *origBB = origPair.first;
auto origBuf = origPair.second;
auto adjBuf = pair.second;
tmp[origBB][origBuf] = adjBuf;
}
// Print original/adjoint buffers per basic block.
auto &s = getADDebugStream() << "Adjoint buffer mapping:\n";
for (auto &origBB : getOriginal()) {
if (!pullbackBBMap.count(&origBB))
continue;
auto bbBufferMap = tmp[&origBB];
s << "bb" << origBB.getDebugID();
s << " (size " << bbBufferMap.size() << "):\n";
for (auto valuePair : bbBufferMap) {
auto origBuf = valuePair.first;
auto adjBuf = valuePair.second;
s << "ORIG: " << origBuf;
s << "ADJ: " << adjBuf << '\n';
}
s << '\n';
}
}

//--------------------------------------------------------------------------//
// Member accessor pullback generation
//--------------------------------------------------------------------------//
Expand Down
7 changes: 4 additions & 3 deletions lib/SILOptimizer/Differentiation/VJPEmitter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -832,15 +832,16 @@ bool VJPEmitter::run() {
// `-enable-strip-ownership-after-serialization` is true.
mergeBasicBlocks(vjp);

LLVM_DEBUG(getADDebugStream()
<< "Generated VJP for " << original->getName() << ":\n"
<< *vjp);

// Generate pullback code.
PullbackEmitter PullbackEmitter(*this);
if (PullbackEmitter.run()) {
errorOccurred = true;
return true;
}
LLVM_DEBUG(getADDebugStream()
<< "Generated VJP for " << original->getName() << ":\n"
<< *vjp);
return errorOccurred;
}

Expand Down