[CodeCompletion] Typecheck without CodeCompletionExpr #32283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
ide-completion-postfixfallback-rdar64176730
branch
2 times, most recently
from
2cfa02c to
0263a21
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
benlangmuir
reviewed
Jun 11, 2020
| func testFallbackPostfix() { | ||
| MyStruct4 { | ||
| 1 | ||
| } #^INIT_FALLBACK^# |
There was a problem hiding this comment.
Is it possible to test without a trailing closure, or is that the only time it reproduces? Also, maybe a test that uses a non-default argument as well.
There was a problem hiding this comment.
The problem only happens after trailing closures because otherwise they are parsed as normal postfix expression completions.
Added a test case with non-defaulted arguments
when falling back to "postfix expression completion" after labeled trailing closure completion. rdar://problem/64176730
rintaro
force-pushed
the
ide-completion-postfixfallback-rdar64176730
branch
from
0263a21 to
5db0f1a
Compare
|
@swift-ci Please smoke test |
benlangmuir
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when falling back to "postfix expression completion" after labeled trailing closure completion.
There were cases where we cannot get any information from
ExprContextAnalysis. We used to give up providing postfix completions after trailing closures. e.g.In such cases, re-type checking is needed, but without
CodeCompletionExprafter the closure.rdar://problem/64176730