[5.3] Mark non-foreign entry points of @objc dynamic methods in generic classes dynamically_replaceable
#32300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eric classes `dynamically_replaceable`
```
* Description:
class Generic<T> {
@objc dynamic func method() {}
}
extension Generic {
@_dynamicReplacement(for:method())
func replacement() {}
}
```
The standard mechanism of using Objective-C categories for dynamically
replacing @objc methods in generic classes does not work.
Instead we mark the native entry point as replaceable.
Because this affects all @objc methods in generic classes (whether there
is a replacement or not) by making the native entry point
`[dynamically_replaceable]` (regardless of optimization mode) we guard this by
the -enable-implicit-dynamic flag because we are late in the release cycle.
* Scope: Before this patch @_dynamicReplacement(for:) was not allowed on
objective c methods in generic classes.
* Risk: Medium. Should only affect entry points that did not work before.
* Reviewed by: Slava Pestov
* Testing: Regression test added
rdar://63679357
|
@swift-ci Please test |
tkremenek
approved these changes
Jun 10, 2020
|
@swift-ci Please test |
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard mechanism of using Objective-C categories for dynamically
replacing @objc methods in generic classes does not work.
Instead we mark the native entry point as replaceable.
Because this affects all @objc methods in generic classes (whether there
is a replacement or not) by making the native entry point
[dynamically_replaceable](regardless of optimization mode) we guard this bythe -enable-implicit-dynamic flag because we are late in the release cycle.
Scope: Before this patch @_dynamicReplacement(for:) was not allowed on
objective c methods in generic classes.
Risk: Medium. Should only affect entry points that did not work before.
Reviewed by: Slava Pestov
Testing: Regression test added
rdar://63679357