Ignore onFastPath builtin while looking for valid static initializer of a global variable #32319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of a global variable
|
@swift-ci smoke test |
|
@swift-ci smoke test OS X |
|
@swift-ci Please smoke test OS X platform |
|
@swift-ci Please smoke test Linux platform |
eeckstein
requested changes
Jun 12, 2020
|
@eeckstein I can't seem to write a test where the builtin needs to be handled in IRGen's emitConstantValue. Looks like onFastPath builtin is generated with no users during SILGen, so the static initializer will not have the onFastPath builtin. Additionally, we never seem to call emitConstantValue for an empty type. |
eeckstein
approved these changes
Jun 15, 2020
There was a problem hiding this comment.
@meg-gupta okay, thanks for checking. If it compiles, then it's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The presence of this builtin has no effect while optimizing initializers of global variables.