[stdlib] Fix UnsafeBufferPointer range subscript getter tests #3233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinzheng
force-pushed
the
az-tests1
branch
2 times, most recently
from
150e392 to
d1d1cd4
Compare
austinzheng
changed the title
All four of the Unsafe*BufferPointer range subscript getter tests (one for each range) were using the same test name string. This caused only one of the four tests to actually be registered to the test suite. This change fixes that issue, and adds a couple more tests for better coverage.
|
@gribozavr I'm not in any rush to get this PR merged, but if it is merged I have a follow-up PR with more tests that depends on this one. (I'm also still working on the hashed collections PR.) |
|
@swift-ci Please test |
|
LGTM. |
| @@ -15,6 +15,8 @@ struct SubscriptGetTest { | |||
| /// The values that should be expected by slicing the UBP, or `nil` if the | |||
| /// test is expected to crash. | |||
| let expectedValues: [Int]? | |||
| /// Same as `expectedValues`, but for closed ranges. `nil` if no difference. | |||
| let expectedClosedValues: [Int]? | |||
There was a problem hiding this comment.
There is let subscriptRangeTests in StdlibCollectionUnittest, which is very similar in intent.
There was a problem hiding this comment.
Those tests don't seem to be instrumented for use with the different types of ranges. Would a follow-up item to fix that be of interest to you?
There was a problem hiding this comment.
Absolutely, having more powerful shared datasets would make all tests stronger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Fixing an issue with a unit test that caused its four variations to not all be run. Sorry! @gribozavr @moiseev
OS X tests pass.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
All four of the Unsafe*BufferPointer range subscript getter tests (one for each range) were using the same test name string. This caused only one of the four tests to actually be registered to the test suite. This change fixes that issue, and adds a couple more tests for better coverage.