[CSGen] Replace getInterfaceType() -> mapTypeIntoContext() for VarD…
#32334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecl with `getType` In `ConstraintGenerator::visitDeclRefExpr` instead of using `getInterfaceType()` for unknown type and later mapping it into context, let's use `getType()` which does that interally, that allows to detect presence of error types in resulting type and abort constraint generation.
|
@swift-ci please smoke test |
CodaFi
approved these changes
Jun 12, 2020
|
@swift-ci please smoke test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ecl with
getTypeIn
ConstraintGenerator::visitDeclRefExprinstead of usinggetInterfaceType()for unknown type and later mapping it intocontext, let's use
getType()which does that interally, thatallows to detect presence of error types in resulting type and
abort constraint generation.