[swift-3.0-preview-2-branch] build-script fixes #3234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argparse was trying to helpfully match it with 'build-swift-stdlib-unittest-extra', but this wasn't our intention. rdar://problem/27030803
- This fixes a regression introduced in a4537e8, where we used to accept a list of concatenated deployment targets as a single argument. - <rdar://problem/26928189> build-script fails to split deployment targets before iterating over them
|
@swift-ci Please test |
gribozavr
changed the title
|
Oops, sorry, looks like this was introduced by my changes in #3027. Thanks for the fix, @gribozavr! 👍 |
|
LGTM |
|
@ddunbar Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: unbreak the 'build-swift-stdlib' option. Argparse was trying to helpfully match it with 'build-swift-stdlib-unittest-extra', but this wasn't our intention.
Scope of the issue: build-script invocations that use
build-swift-stdlib.Risk: low.
Reviewed by: nobody.
Testing: manual.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.