[Runtime] Scribble on metadata allocations. #32408
Conversation
|
@swift-ci please test |
stdlib/public/runtime/Metadata.cpp
Outdated
| // SWIFT_DEBUG_ENABLE_MALLOC_SCRIBBLE environment variable is set. | ||
| static OnceToken_t getenvToken; | ||
| SWIFT_ONCE_F(getenvToken, checkMallocScribbleEnvironmentVariable, nullptr); | ||
| if (SWIFT_UNLIKELY(_swift_debug_mallocScribbleEnabled)) { |
There was a problem hiding this comment.
The SWIFT_DEBUG_ENABLE_MALLOC_SCRIBBLE() call will compile down to a SWIFT_ONCE_F and an access to a global variable, so you can remove your own SWIFT_ONCE_F and global and just check that directly. (You might have seen me doing this with _swift_debug_metadataAllocationIterationEnabled, but that's only because there's additional setup needed when it's enabled.)
There was a problem hiding this comment.
Thank you for the explanation! Fixed.
|
Build failed |
nate-chandler
force-pushed
the
runtime/memset-pattern-metadata-on-flag
branch
from
0ff21a1 to
4d4d90e
Compare
Previously, when NDEBUG was not defined, the allocations made for value metadata records were filled with 0xAA bytes. Here, that behavior is both expanded to all metadata records and enabled in release builds when the environment variable SWIFT_DEBUG_ENABLE_MALLOC_SCRIBBLE is set.
|
Build failed |
nate-chandler
force-pushed
the
runtime/memset-pattern-metadata-on-flag
branch
from
4d4d90e to
5f67ef4
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please clean test os x platform |
Previously, when
NDEBUGwas not defined, the allocations made for value metadata records were filled with0xAAbytes. Here, that behavior is both expanded to all metadata records and enabled in release builds when the environment variableSWIFT_DEBUG_ENABLE_MALLOC_SCRIBBLEis set.