[build-script] Isolate CMake from the system #32437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building on Darwin, we're supposed to build against the SDK, not the host system. Isolate the build further from the system.
|
@swift-ci test |
|
@swift-ci please test source compatibility |
edymtt
approved these changes
Jun 17, 2020
|
Build failed |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
gottesmm
reviewed
Jun 17, 2020
| @@ -701,6 +701,11 @@ class BuildScriptInvocation(object): | |||
| "--host-lipo", toolchain.lipo, | |||
| ] | |||
|
|
|||
| # Isolate build from the system; Darwin toolchains build against SDKs. | |||
| args.extra_cmake_options.append( | |||
| '-DCMAKE_IGNORE_PATH=/usr/lib;/usr/local/lib;/lib' | |||
There was a problem hiding this comment.
Can you add to the comment here what type of problems result from us not doing this?
There was a problem hiding this comment.
Or you know what. I think this is pretty common sense. Nm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building on Darwin, we're supposed to build against the SDK,
not the host system. Isolate the build further from the system.
This continues the work of #32419