Skip to content

[CodeCompletion] Suggest 'macOS' instead of 'OSX' #32440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 17, 2020

'macOS' is the preferred name for specifying the platform. Since 'OSX' is deprecated, we don't need to suggest 'OSX' variants.

rdar://problem/64379019

@rintaro
Copy link
Member Author

rintaro commented Jun 17, 2020

@swift-ci Please smoke test

@rintaro rintaro requested a review from akyrtzi June 17, 2020 19:48
@theblixguy theblixguy changed the title [CodeCompeltion] Suggest 'macOS' instead of 'OSX' [CodeCompletion] Suggest 'macOS' instead of 'OSX' Jun 17, 2020
'macOS' is the preferred name for specifying the platform. Since 'OSX'
is deprecated, we don't need to suggest 'OSX' variants.

rdar://problem/64379019
@rintaro rintaro force-pushed the ide-completion-platform-rdar64379019 branch from f199663 to d4da603 Compare June 17, 2020 21:09
@rintaro
Copy link
Member Author

rintaro commented Jun 17, 2020

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Jun 17, 2020

@rintaro rintaro merged commit 6a8d292 into swiftlang:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants