[Runtime] Add entry point to compare type context descriptors. #32476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please clean test os x platform |
nate-chandler
force-pushed
the
runtime/add-swift_compareTypeContextDescriptors
branch
from
81739f6 to
3c4e7bf
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please clean test os x platform |
jckarter
approved these changes
Jun 22, 2020
The new function `swift_compareTypeContextDescriptors` is equivalent to a call through to swift::equalContexts. The implementation it the same as that of swift::equalContexts with the following removals: - Handling of context descriptors of kind other outside of ContextDescriptorKind::Type_First...ContextDescriptorKind::Type_Last. Because the arguments are both TypeContextDescriptors, the kinds are known to fall within that range. - Casting to TypeContextDescriptor. The arguments are already of that type. For now, the new function has "future" availability.
nate-chandler
force-pushed
the
runtime/add-swift_compareTypeContextDescriptors
branch
from
3c4e7bf to
2c6d7d7
Compare
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new function
swift_compareTypeContextDescriptorsis equivalent to a call through toswift::equalContexts. The implementation it the same as that ofswift::equalContextswith the following removals:ContextDescriptorKind::Type_First...ContextDescriptorKind::Type_Last. Because the arguments are bothTypeContextDescriptors, the kinds are known to fall within that range.TypeContextDescriptor. The arguments are already of that type.For now, the new function has "future" availability.