[5.3][ConstraintSystem] Don't propagate holes through supertype inference #32490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disallow holes to be inferred as supertype bindings while inferring bindings from other type variables (based on transitivity of subtype conversions), otherwise it would be possible to record a hole without recording associated fix. Resolves: rdar://problem/64368545 (cherry picked from commit 2283208)
|
@swift-ci please test |
DougGregor
approved these changes
Jun 22, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #32449
Disallow holes to be inferred as supertype bindings while inferring
bindings from other type variables (based on transitivity of subtype
conversions), otherwise it would be possible to record a hole without
recording associated fix.
Scope: Affects situations in diagnostic mode where there is a subtype relationship between two type variables and supertype has a hole as one of the potential bindings.
Resolves: rdar://problem/64368545
Risk: Very low
Testing: Added regression tests
Reviewer: @DougGregor
Resolves: rdar://problem/64368545
(cherry picked from commit 2283208)