[5.3][SourceKit/CodeFormat] Fix multi-line array literal elements not indenting relative to their first line. #32583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #32582 for 5.3
Explanation:
Multi-line array literal elements were not indenting relative to their first line as they did before the indentation overhaul. Each item in an array literal wasn't being reported as an indent context, so we under-indented their continuation lines as in the example below:
This change makes them an indent context giving the behavior below:
Scope: Affects the indentation of all multi-line expressions expression within array literals.
Risk: Low. It's a small targeted fix that only affects sourcekitd's CodeFormat request. It has no impact on sourcekitd's other requests or the compiler.
Origination: Since the indentation overhaul in 5.3.
Testing: Added a regression test for this case and all existing tests pass.
Reviewer: Ben Langmuir (@benlangmuir) on the master PR
Resolves rdar://problem/64834040