test: exit properly with swift_build_sdk_interface
#32616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sys.exit` takes an integral value in the range of `0-127`. Python 3 is much more stringent about this and will convert the value if it is out of the range to 1. On Windows, explicitly use `ExitProcess` to ensure that we get the correct value on the exit code which matters to `not`.
|
CC: @tachoknight @drexin |
|
@swift-ci please test |
drexin
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sys.exittakes an integral value in the range of0-127. Python 3 ismuch more stringent about this and will convert the value if it is out
of the range to 1. On Windows, explicitly use
ExitProcessto ensurethat we get the correct value on the exit code which matters to
not.Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.