[build] Pass target to linker for host tools for Apple SDKs #32618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is basically a rehash of swiftlang#31794 to add `-target` flag to the linker invocation when building against Apple SDKs. Addresses rdar://64911978
|
@swift-ci please smoke test |
compnerd
requested changes
Jun 30, 2020
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
|
@swift-ci please clean test Windows platform |
|
@swift-ci please smoke test |
|
@swift-ci please clean test Windows platform |
|
@swift-ci please smoke test |
|
@swift-ci please clean test Windows platform |
edymtt
changed the title
compnerd
reviewed
Jul 1, 2020
compnerd
approved these changes
Jul 1, 2020
|
@swift-ci please smoke test |
|
@swift-ci please clean test Windows platform |
|
@swift-ci please test Windows platform |
|
@swift-ci please clean test Windows platform |
|
I think that the Windows test was a flake ... |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this refactor some code touched as part of #31794 to better fit into the work done in #32120 -- in detail
_add_host_variant_c_compile_link_flagsis now invoked by bothadd_swift_host_libraryandadd_swift_host_library_add_host_variant_c_compile_link_flagsnow sets the target in linker arguments when building against Apple SDKsAddresses rdar://64911978