Add a new -sil-disable-only-function flag #32622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
approved these changes
Jun 30, 2020
| @@ -87,6 +87,9 @@ llvm::cl::list<std::string> | |||
| SILDisablePass("sil-disable-pass", llvm::cl::CommaSeparated, | |||
| llvm::cl::desc("Disable passes " | |||
| "which contain a string from this list")); | |||
| llvm::cl::list<std::string> SILDisableOnlyFun( | |||
| "sil-disable-only-function", llvm::cl::CommaSeparated, | |||
There was a problem hiding this comment.
Can you add pass to the name? Maybe: -sil-disable-pass-only-function=. Then it is really clear.
| @@ -592,7 +601,7 @@ runFunctionPasses(unsigned FromTransIdx, unsigned ToTransIdx) { | |||
|
|
|||
| void SILPassManager::runModulePass(unsigned TransIdx) { | |||
| auto *SMT = cast<SILModuleTransform>(Transformations[TransIdx]); | |||
| if (isDisabled(SMT)) | |||
| if (isDisabled(SMT, nullptr)) | |||
There was a problem hiding this comment.
Should this be a default nullptr value?
| static bool isDisabled(SILTransform *T) { | ||
| static bool isDisabled(SILTransform *T, SILFunction *F) { | ||
| if (!SILDisableOnlyFun.empty() && F && | ||
| SILDisableOnlyFun.end() == std::find(SILDisableOnlyFun.begin(), |
There was a problem hiding this comment.
IIRC, we have a range for std::find, no?
This will enable us apply -sil-disable-pass only on certain functions
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable us apply -sil-disable-pass only on certain functions