Skip to content

[generics] Add an option that causes the generic specializer to validate newly specialized functions earlier when we have more information that we can put into a pretty stack trace. #32627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

I also added support for creating a PrettyStackTraceSILFunction from a twine.

@gottesmm gottesmm requested a review from meg-gupta June 30, 2020 20:38
@gottesmm
Copy link
Contributor Author

@swift-ci test

@gottesmm gottesmm force-pushed the pr-d8d0aecd8a64d1dd705c2b441270bd8c65760629 branch from be42002 to 793008f Compare June 30, 2020 20:40
@gottesmm
Copy link
Contributor Author

@swift-ci test

3 similar comments
@gottesmm
Copy link
Contributor Author

@swift-ci test

@gottesmm
Copy link
Contributor Author

@swift-ci test

@gottesmm
Copy link
Contributor Author

@swift-ci test

…ate newly specialized functions earlier when we have more information that we can put into a pretty stack trace.

I also added support for creating a PrettyStackTraceSILFunction from a twine.
@gottesmm gottesmm force-pushed the pr-d8d0aecd8a64d1dd705c2b441270bd8c65760629 branch from 793008f to 0750b0b Compare June 30, 2020 20:43
@gottesmm
Copy link
Contributor Author

@swift-ci test

@gottesmm
Copy link
Contributor Author

This is actually a NFC change now that everything is behind the flag, so I am going to do a smoke test.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 793008ffad4b6bd33d3b29db73ff0835a44a6032

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

5 similar comments
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - be42002f5a656ef1ad353f16c2530a34ef0ecffb

@gottesmm
Copy link
Contributor Author

@swift-ci test windows platform

@gottesmm gottesmm merged commit 4a50e23 into swiftlang:master Jul 1, 2020
@gottesmm gottesmm deleted the pr-d8d0aecd8a64d1dd705c2b441270bd8c65760629 branch July 1, 2020 02:56
@gottesmm
Copy link
Contributor Author

gottesmm commented Jul 1, 2020

@meg-gupta thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants