Skip to content

NFC: Make SILType.h and SILDeclRef.h not depend on SIL/*.h #32645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

davezarzycki
Copy link
Contributor

SILType and SILDeclRef do not actually need anything from SIL/*.h. Also, a few dependencies can be pushed out of the headers into cpp files to speed up incremental rebuilds.

SILType and SILDeclRef do not actually need anything from SIL/*.h. Also,
a few dependencies can be pushed out of the headers into cpp files to
speed up incremental rebuilds.
@davezarzycki
Copy link
Contributor Author

@swift-ci please test

@davezarzycki
Copy link
Contributor Author

davezarzycki commented Jul 1, 2020

@jckarter – After this clean up, I'd like propose moving SILType.h from include/swift/SIL to include/swift/AST. This would simplify a bunch of things and allow for easier self-consistency checks in the SIL specific types of the AST type system.

@jckarter
Copy link
Contributor

jckarter commented Jul 1, 2020

In principle, I feel like SILType-specific consistency checks could go in the SIL library too. It would be nice if we could drive a stronger wedge between SIL types and AST types, to help make it harder to confuse lowered types and formal types when working in SILGen, optimization passes, and IRGen, instead of making them more similar.

@davezarzycki
Copy link
Contributor Author

davezarzycki commented Jul 1, 2020

Okay. Let me think about that. In any case, this pull request is still worthwhile, right? This is just header dependency clean up.

@jckarter
Copy link
Contributor

jckarter commented Jul 1, 2020

Sure, this patch looks good.

@davezarzycki davezarzycki merged commit 46a315e into swiftlang:master Jul 1, 2020
@davezarzycki davezarzycki deleted the pr32645 branch July 1, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants