Skip to content

Disable a RUN line in osx-targets.swift #32679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Jul 2, 2020

Darwin 55 is now translated to macOS 46 after the LLVM changes landed that added support for macOS 11. This change temporarily disables the RUN line in the test that uses the darwin55 triple until the appropriate fix is upstreamed on the swift side.

Darwin 55 is now translated to macOS 46 after the LLVM changes landed that added support for macOS 11. This change temporarily disables the RUN line in the test that uses the `darwin55` triple until the appropriate fix is upstreamed on the swift side.
@hyp
Copy link
Contributor Author

hyp commented Jul 2, 2020

@swift-ci please smoke test

@hyp hyp requested review from devincoughlin and fredriss July 2, 2020 15:48
@compnerd
Copy link
Member

compnerd commented Jul 2, 2020

Perhaps it makes sense to have an associated SR?

@compnerd
Copy link
Member

compnerd commented Jul 2, 2020

@swift-ci please test Windows platform

@compnerd
Copy link
Member

compnerd commented Jul 2, 2020

Windows failure is caused by #32666

@hyp
Copy link
Contributor Author

hyp commented Jul 2, 2020

We don't have an SR. This will be fixed when swift's upstreaming PR is posted.

@hyp hyp merged commit ed0e628 into master Jul 2, 2020
@hyp hyp deleted the disable-osx-targets-swift-run-line branch July 2, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants