Fix eight warnings on Linux. #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1318,6 +1315,7 @@ bool ModelASTWalker::findUrlStartingLoc(StringRef Text, | |||
| return true; | |||
| } | |||
| } | |||
| #endif | |||
| return false; | |||
There was a problem hiding this comment.
Wouldn't this cause equivalent unreachable code warnings for return false?
Could you do #ifdef ... #else ... #endif instead?
There was a problem hiding this comment.
It looks like the 'return false' is reachable with and without SWIFT_HAVE_WORKING_STD_REGEX?
There was a problem hiding this comment.
I patched it both ways but settled on this way because it looked cleaner.
Fix spurious docs warning that @in and @in_guaranteed should be ``fn``. Add ``#ifdef SWIFT_OBJC_INTEROP`` to silence a -Wunused-function on linux since that function is only used from within that #ifdef elsewhere. Fix three -Wunused-function warnings on linux. Fix two -Wunreachable-code warnings on linux dealing with SWIFT_HAVE_WORKING_STD_REGEX.
|
I think the latest version is OK. Merging. |
slavapestov
added a commit
that referenced
this pull request
Dec 8, 2015
Fix eight warnings on Linux.
kateinoigakukun
added a commit
to kateinoigakukun/swift
that referenced
this pull request
Mar 6, 2020
Merge upstream 2020 03 06
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Oct 22, 2020
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Add SwiftGraph for Swift 4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.